Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node nvm fallback implement for zsh & bash #974

Closed
wants to merge 48 commits into from
Closed

Node nvm fallback implement for zsh & bash #974

wants to merge 48 commits into from

Conversation

gauravsaini04
Copy link
Contributor

@gauravsaini04 gauravsaini04 commented May 16, 2024 •
edited
Loading

Feature name:

  • Node

Description:

This PR introduces the following functionality :

  • Fallback methods implementation for node - nvm installation.

Changelog:

  • Updated install.sh
  • Created bash_install_node.sh file - Corresponding installation file for both bash & zsh execution env.

Checklist:

  • Checked that applied changes work as expected

@gauravsaini04 gauravsaini04 marked this pull request as ready for review May 17, 2024 00:16
@gauravsaini04 gauravsaini04 requested a review from a team as a code owner May 17, 2024 00:16
gauravsaini04 and others added 12 commits May 17, 2024 02:41
@gauravsaini04
jq installation failing in centos-7 - fix
6fa2789
@gauravsaini04
linter failing fix on pr test runs
4551675
@gauravsaini04
fedora failing test - fix
6a7bb95
@gauravsaini04
change for linter
136c3e8
@gauravsaini04
misc change - for failing fedora for epel-release while centos needs …
3816a38 
…it for jq
@gauravsaini04
Merge branch 'devcontainers:main' into node_nvm_fallback_implement_zs…
4aaa7d8 
…h_bash
@gauravsaini04
Merge branch 'devcontainers:main' into node_nvm_fallback_implement_zs…
70c1504 
…h_bash
@gauravsaini04
Merge branch 'devcontainers:main' into node_nvm_fallback_implement_zs…
ee16e7c 
…h_bash
@gauravsaini04
Merge branch 'devcontainers:main' into node_nvm_fallback_implement_zs…
fc46f25 
…h_bash
@gauravsaini04
Merge branch 'devcontainers:main' into node_nvm_fallback_implement_zs…
3d74101 
…h_bash
@gauravsaini04
Merge branch 'devcontainers:main' into node_nvm_fallback_implement_zs…
ea9ed72 
…h_bash
@samruddhikhandale
Merge branch 'main' into node_nvm_fallback_implement_zsh_bash
a9907b3
samruddhikhandale
samruddhikhandale requested changes Jun 5, 2024
View reviewed changes
src/node/bash_install_node.sh Outdated Show resolved Hide resolved
src/node/install.sh Show resolved Hide resolved
src/node/install.sh Outdated Show resolved Hide resolved
src/node/install.sh Outdated Show resolved Hide resolved
samruddhikhandale
samruddhikhandale requested changes Jun 6, 2024
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you help fix the failing tests?

@gauravsaini04
change for jq failing to be found in centos-7 test case
23b730e
@gauravsaini04
Merge branch 'devcontainers:main' into node_nvm_fallback_implement_zs…
f434cc2 
…h_bash
@gauravsaini04
Merge branch 'devcontainers:main' into node_nvm_fallback_implement_zs…
ffaa440 
…h_bash
@gauravsaini04
Merge remote-tracking branch 'origin/main' into node_nvm_fallback_imp…
ad65b40 
…lement_zsh_bash
@gauravsaini04
Merge branch 'devcontainers:main' into node_nvm_fallback_implement_zs…
97cfc3e 
…h_bash
@gauravsaini04
Merge branch 'main' into node_nvm_fallback_implement_zsh_bash
9d934ae
@gauravsaini04
Merge branch 'devcontainers:main' into node_nvm_fallback_implement_zs…
5e55f5d 
…h_bash
@gauravsaini04
Merge branch 'devcontainers:main' into node_nvm_fallback_implement_zs…
200cb65 
…h_bash
@gauravsaini04
Merge branch 'devcontainers:main' into node_nvm_fallback_implement_zs…
cbd7c8f 
…h_bash
@gauravsaini04
Merge branch 'devcontainers:main' into node_nvm_fallback_implement_zs…
5e1cf32 
…h_bash
@gauravsaini04
Merge branch 'devcontainers:main' into node_nvm_fallback_implement_zs…
d1f146e 
…h_bash
@gauravsaini04
Merge branch 'devcontainers:main' into node_nvm_fallback_implement_zs…
6068423 
…h_bash
@gauravsaini04
Merge branch 'devcontainers:main' into node_nvm_fallback_implement_zs…
21867b8 
…h_bash
@gauravsaini04
Merge branch 'devcontainers:main' into node_nvm_fallback_implement_zs…
a5988c5 
…h_bash
@gauravsaini04
Merge branch 'devcontainers:main' into node_nvm_fallback_implement_zs…
b5ee1c1 
…h_bash
@gauravsaini04
Merge branch 'devcontainers:main' into node_nvm_fallback_implement_zs…
8613da3 
…h_bash
@gauravsaini04
Merge branch 'devcontainers:main' into node_nvm_fallback_implement_zs…
a4bb5c2 
…h_bash
@gauravsaini04
Merge branch 'devcontainers:main' into node_nvm_fallback_implement_zs…
9ca9ff2 
…h_bash
@gauravsaini04
Merge branch 'devcontainers:main' into node_nvm_fallback_implement_zs…
fb1e45a 
…h_bash
@gauravsaini04
Merge branch 'devcontainers:main' into node_nvm_fallback_implement_zs…
9c22b5f 
…h_bash
@gauravsaini04
Merge remote-tracking branch 'refs/remotes/origin/node_nvm_fallback_i…
0f185d4 
…mplement_zsh_bash' into node_nvm_fallback_implement_zsh_bash
@gauravsaini04
Merge branch 'main' into node_nvm_fallback_implement_zsh_bash
6abbe72
@samruddhikhandale
Copy link
Member

Thanks, the changes look complex. Hence, let's hold on to merging this unless we hear more feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samruddhikhandale samruddhikhandale samruddhikhandale requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gauravsaini04 @samruddhikhandale