Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common-utils zshrc issue fix #1111

Merged
merged 5 commits into from
Oct 17, 2024
Merged

common-utils zshrc issue fix #1111

merged 5 commits into from
Oct 17, 2024

Conversation

prathameshzarkar9
Copy link
Contributor

Issue 1035
common-utils overwrites .zshrc coming from image built with common-utils already

Feature Name

  • common-utils

Changelog

  • Changes to main.sh for features issue

Checklist

  • user provided commands appended to .zshrc file should not overwrite the existing .zshrc file

@prathameshzarkar9 prathameshzarkar9 requested a review from a team as a code owner September 2, 2024 09:25
@prathameshzarkar9 prathameshzarkar9 mentioned this pull request Sep 2, 2024
Closed
samruddhikhandale
samruddhikhandale requested changes Sep 11, 2024
View reviewed changes
src/common-utils/main.sh Show resolved Hide resolved
src/common-utils/main.sh Outdated Show resolved Hide resolved
@samruddhikhandale samruddhikhandale merged commit 88253ef into devcontainers:main Oct 17, 2024
12 checks passed
This was referenced Nov 1, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eitsupi eitsupi eitsupi left review comments

@gvatsal60 gvatsal60 gvatsal60 approved these changes

@samruddhikhandale samruddhikhandale samruddhikhandale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prathameshzarkar9 @samruddhikhandale @gvatsal60 @eitsupi