Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features contribute lifecycle hooks #390

Merged
merged 47 commits into from
Mar 2, 2023

Commits on Jan 18, 2023

  1. Configuration menu
    Copy the full SHA
    efa0f62 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. Configuration menu
    Copy the full SHA
    279da40 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2023

  1. Configuration menu
    Copy the full SHA
    f43350e View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' of https://github.com/devcontainers/cli into josh…

    …spicer/features-lifecycles-hooks
    joshspicer authored Jan 23, 2023
    Configuration menu
    Copy the full SHA
    652c249 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. Configuration menu
    Copy the full SHA
    b3c6d87 View commit details
    Browse the repository at this point in the history
  2. test with ${featureRoot}

    joshspicer authored Jan 24, 2023
    Configuration menu
    Copy the full SHA
    d0d99fc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9aeade3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b88f1cd View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. add

    joshspicer authored Feb 1, 2023
    Configuration menu
    Copy the full SHA
    909e0fe View commit details
    Browse the repository at this point in the history
  2. typecheck

    joshspicer authored Feb 1, 2023
    Configuration menu
    Copy the full SHA
    93ed16b View commit details
    Browse the repository at this point in the history
  3. improve test

    joshspicer authored Feb 1, 2023
    Configuration menu
    Copy the full SHA
    780c346 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d0323e3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cd591d3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b5ec2f0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1502b47 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. Merge branch 'main' of https://github.com/devcontainers/cli into josh…

    …spicer/features-lifecycles-hooks
    joshspicer authored Feb 2, 2023
    Configuration menu
    Copy the full SHA
    af35b5d View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. update test

    joshspicer authored Feb 3, 2023
    Configuration menu
    Copy the full SHA
    bbadb67 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2023

  1. Display the 'origin' of the lifecycle command in the output log durin…

    …g 'up'
    
    Logs like 'Running the postCreateCommand from devcontainer.json'
    are updated to include the origin of the command
    
    e.g: 'Running the postCreateCommand from Feature 'common-utils'.
    
    This patch adds in a mapping object that is passed along and used to
    map a command to an origin.
    
    This change is a bit less efficient, with the added benefit of not
    needing to modify the existing merging logic.
    joshspicer authored Feb 4, 2023
    Configuration menu
    Copy the full SHA
    0d3941d View commit details
    Browse the repository at this point in the history
  2. Change copy path for Features on-container from /tmp-build-features t…

    …o /opt/build-features
    
    This is to support resuming a container in Codespaces with
    Feature-contributed lifecycle hooks. Codespaces bind-mounts a different
    volume on top of /tmp, so the container's /tmp directory is not
    persisted.
    joshspicer authored Feb 4, 2023
    Configuration menu
    Copy the full SHA
    f320096 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. Configuration menu
    Copy the full SHA
    9596961 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    311a397 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0350081 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    26406cf View commit details
    Browse the repository at this point in the history
  5. rm -rf test dir

    joshspicer authored Feb 6, 2023
    Configuration menu
    Copy the full SHA
    cafa379 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cf819cf View commit details
    Browse the repository at this point in the history
  7. unused test stub

    joshspicer authored Feb 6, 2023
    Configuration menu
    Copy the full SHA
    7b32586 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0f1bfd5 View commit details
    Browse the repository at this point in the history
  9. Merge branch 'main' of https://github.com/devcontainers/cli into josh…

    …spicer/features-lifecycles-hooks
    joshspicer authored Feb 6, 2023
    Configuration menu
    Copy the full SHA
    3e5f804 View commit details
    Browse the repository at this point in the history
  10. increase test timeouts

    joshspicer authored Feb 6, 2023
    Configuration menu
    Copy the full SHA
    5e7ebcb View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. '' -> ''

    joshspicer authored Feb 7, 2023
    Configuration menu
    Copy the full SHA
    c000b10 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. Configuration menu
    Copy the full SHA
    6687ad4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8ede783 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    91e160b View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. cannot change line 256

    joshspicer authored Feb 10, 2023
    Configuration menu
    Copy the full SHA
    e8b4b6f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bff51a9 View commit details
    Browse the repository at this point in the history
  3. update existing test

    joshspicer authored Feb 10, 2023
    Configuration menu
    Copy the full SHA
    07ad411 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    99836c3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2e2731f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4c37690 View commit details
    Browse the repository at this point in the history
  7. missing semicolon

    joshspicer authored Feb 10, 2023
    Configuration menu
    Copy the full SHA
    2adef08 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2023

  1. Configuration menu
    Copy the full SHA
    59c1f4a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cd87a51 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2023

  1. Configuration menu
    Copy the full SHA
    d4f974b View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2023

  1. Configuration menu
    Copy the full SHA
    dd7667b View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. Configuration menu
    Copy the full SHA
    b4e40a5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    73c3a4f View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2023

  1. Configuration menu
    Copy the full SHA
    14a1c33 View commit details
    Browse the repository at this point in the history