Temporary fix for broken inactiveTransverseDeflectingCavity
in Segment
#296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements a temporary fix that prevents inactive
TransverseDeflectingCavity
s to take part in transfer map reduction.Ideally, this should be fixed properly at some point to allow for fast tracking by implementing the
transfer_map
function or inheriting it fromDrift
in the future, to make sure this part of Cheetah is also as fast as it can be. For now the workaround for being fast is to replace inactive elements withDrift
using the respective functions inSegment
for doing exactly that.Motivation and Context
Calling
transfer_map
onTransverseDeflectingCavity
would cause aNotImplementedError
to be raised and therefore prevent tracking through anySegment
that had an inactiveTransverseDeflectingCavity
in it.Fixes #290.
Types of changes
Checklist
flake8
(required).pytest
tests pass (required).pytest
on a machine with a CUDA GPU and made sure all tests pass (required).Note: We are using a maximum length of 88 characters per line.