Move draggable menus outside of iframe when possible #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed other commits relating to #553 |
…outside the bounds of the chat iframe when embedded inside of a page
AlexDavies8
force-pushed
the
global-dragging
branch
from
b783ea0 to
e3f2e18
Compare
|
I understand the implementation broadly speaking, but some parts are extremely difficult to follow. There are also UX issues, such as only clicking in the the chat can dismiss a draggable window, not the stream panel. Ultimately, I don't think this is something I'm interested in maintaining at the moment. One thing we may do in the future is make it so that chat isn't embedded in an iframe on the Bigscreen page. That would give us this functionality for "free." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows draggable menus (I think ChatUserInfoMenu is the only one atm) to be dragged anywhere on the page when chat is embedded as an iframe (i.e. it can escape the iframe bounds).
Sometimes this may not be possible as some sites have restrictions on what an iframe is able to control on the parent page, in which case it will behave as it currently does and clip to the iframe bounds.
This also supports arbitrarily nested iframes (for example if you had an iframe with bigscreen in, the menus from the chat in there would be able to be dragged anywhere on the page.
Video.mp4