Skip to content

Commit

Permalink
Fix issue with expired events not being removed
Browse files Browse the repository at this point in the history
The event enter animation had a higher specificity than the remove
animation, which meant the remove animation never took effect. Simply
flipping the order of the two rulesets fixes the issue.
  • Loading branch information
11k committed Nov 13, 2024
1 parent bf7b3a5 commit f477329
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions assets/chat/css/chat/event-bar/_event-bar-event.scss
Original file line number Diff line number Diff line change
Expand Up @@ -102,13 +102,15 @@
transform: scale(1.05);
}

&.removed {
animation: event-bar-disappear 500ms linear;
}

// Ensure `removed` can override `enter` because `enter` is not removed from
// the event after the animation completes.
&.enter {
animation: event-bar-appear 500ms linear;
}

&.removed {
animation: event-bar-disappear 500ms linear;
}
}

@keyframes event-bar-appear {
Expand Down

0 comments on commit f477329

Please sign in to comment.