Allow desi_proc_night to restart mid processing in calibrations #2392
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
desi_proc_night is designed to pick up where it left off based on information saved in the processing_table. However, there was a bug in the code that applies only to nights with some processing table entries and no science data where it was exiting due to an
if
statement checking whether there were new science exposures. Theif
statement was meant to speed up the exiting of the script so that it didn't need to run multiple computationally intensive functions just to arrive at the same conclusion. Therefore, I decided not to remove the logic, but improve it such that it desi_proc_night still quickly exits if no new science exposures have been observed while fixing the case that was failing before.Case that was failing before:
We had processed 4 arcs but nothing else. (This arose due to a bad camera leading a job to fail. After Abhijeet edited the exposure table to flag the bad cameras I removed later entries in the processing table and tried to rerun, but that failed due to the above issue). This branch now works in that instance.