Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow desi_proc_night to restart mid processing in calibrations #2392

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

akremin
Copy link
Member

@akremin akremin commented Oct 11, 2024

desi_proc_night is designed to pick up where it left off based on information saved in the processing_table. However, there was a bug in the code that applies only to nights with some processing table entries and no science data where it was exiting due to an if statement checking whether there were new science exposures. The if statement was meant to speed up the exiting of the script so that it didn't need to run multiple computationally intensive functions just to arrive at the same conclusion. Therefore, I decided not to remove the logic, but improve it such that it desi_proc_night still quickly exits if no new science exposures have been observed while fixing the case that was failing before.

Case that was failing before:
We had processed 4 arcs but nothing else. (This arose due to a bad camera leading a job to fail. After Abhijeet edited the exposure table to flag the bad cameras I removed later entries in the processing table and tried to rerun, but that failed due to the above issue). This branch now works in that instance.

@akremin akremin requested a review from sbailey October 11, 2024 23:28
@coveralls
Copy link

Coverage Status

coverage: 30.192% (-0.005%) from 30.197%
when pulling 46dae3f on daily_cal_no_science
into e98abca on main.

@sbailey sbailey merged commit 05bcd76 into main Oct 11, 2024
26 checks passed
@sbailey sbailey deleted the daily_cal_no_science branch October 11, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants