Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specstatus compatibility fix #2384

Merged
merged 6 commits into from
Oct 9, 2024
Merged

specstatus compatibility fix #2384

merged 6 commits into from
Oct 9, 2024

Conversation

weaverba137
Copy link
Member

This PR removes the UPDATED column from a tiles table so it remains compatible with the specstatus table.

@weaverba137 weaverba137 self-assigned this Oct 8, 2024
@coveralls
Copy link

coveralls commented Oct 8, 2024

Coverage Status

coverage: 30.198% (+0.004%) from 30.194%
when pulling 513774a on tiles-specstatus-compatibility
into d8630a4 on main.

@weaverba137
Copy link
Member Author

In addition @sbailey found a bug in desi_tsnr_afterburner that was placing EFFTIME_SPEC values in the GOALTYPE column. That should be fixed now.

@sbailey
Copy link
Contributor

sbailey commented Oct 9, 2024

This fixes a bug in desi_tsnr_afterburner, and fixes a crash-inducing incompatibility with the new UPDATED column in the tiles-daily.csv file. We're still checking the impact of the patched changes in tiles-daily.csv and how they propagate to tiles-specstatus.ecsv, but these changes at minimum are necessary so I will merge this now.

@sbailey sbailey merged commit 6fc2673 into main Oct 9, 2024
26 checks passed
@sbailey sbailey deleted the tiles-specstatus-compatibility branch October 9, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants