Skip to content

Commit

Permalink
update comments
Browse files Browse the repository at this point in the history
  • Loading branch information
segasai committed Nov 20, 2024
1 parent e53624a commit c4a5a8f
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
2 changes: 1 addition & 1 deletion py/desispec/scripts/trace_shifts.py
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ def fit_trace_shifts(image, args):
# the traceset of the psf is not used here
psf = read_specter_psf(args.psf)
(tset.y_vs_wave_traceset._coeff,
(wave_external, dwave_external, dwave_err_external)) = shift_ycoef_using_external_spectrum(psf=psf, xytraceset=tset,
wave_external, dwave_external, dwave_err_external) = shift_ycoef_using_external_spectrum(psf=psf, xytraceset=tset,
image=image, fibers=fibers,
spectrum_filename=spectrum_filename,
degyy=args.degyy, width=7)
Expand Down
7 changes: 6 additions & 1 deletion py/desispec/trace_shifts.py
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,8 @@ def compute_dy_from_spectral_cross_correlations_of_frame(flux, ivar, wave , xcoe
ey : 1D array of uncertainties on dy
fiber : 1D array of fiber ID (first fiber = 0)
wave : 1D array of wavelength
dwave : 1D array of wavelength offsets
dwave_err: 1D array of wavelength offset uncertainties
"""
log=get_logger()
Expand Down Expand Up @@ -823,6 +825,9 @@ def shift_ycoef_using_external_spectrum(psf, xytraceset, image, fibers,
Returns:
ycoef : 2D np.array of same shape as input, with modified Legendre coefficients for each fiber to convert wavelength to YCCD
wave: : 1D array of wavelengths for which offsets are computed
dwave: : 1D array of wavelength offsets
dwave_err: 1D array of wavelength offset uncertainties
"""
log = get_logger()
Expand Down Expand Up @@ -922,7 +927,7 @@ def shift_ycoef_using_external_spectrum(psf, xytraceset, image, fibers,
for fiber in range(ycoef.shape[0]) :
ycoef[fiber] += dycoef

return ycoef, (wave_for_dy, dwave_list, dwave_err_list)
return ycoef, wave_for_dy, dwave_list, dwave_err_list



Expand Down

0 comments on commit c4a5a8f

Please sign in to comment.