Merge pull request #104 from designmynight/deleteByQuery

fix: use deleteByQuery to allow multiple deletes
designmynight · Sep 11, 2020 · deb64c3 · deb64c3
2 parents 91dfe54 + 44fce93
commit deb64c3
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 16 deletions.
diff --git a/src/Connection.php b/src/Connection.php
@@ -165,7 +165,7 @@ public function delete($query, $bindings = [])
         return $this->run(
             $query,
             $bindings,
-            Closure::fromCallable([$this->connection, 'delete'])
+            Closure::fromCallable([$this->connection, 'deleteByQuery'])
         );
     }
 

diff --git a/src/QueryBuilder.php b/src/QueryBuilder.php
@@ -764,7 +764,7 @@ public function delete($id = null): bool
 
         $result = $this->connection->delete($this->grammar->compileDelete($this));
 
-        return !empty($result['found']);
+        return !empty($result['deleted']);
     }
 
     public function __call($method, $parameters)

diff --git a/src/QueryGrammar.php b/src/QueryGrammar.php
@@ -1133,20 +1133,7 @@ public function compileInsert(Builder $builder, array $values): array
      */
     public function compileDelete(Builder $builder): array
     {
-        $params = [
-            'index' => $builder->from . $this->indexSuffix,
-            'id'    => (string) $builder->wheres[0]['value']
-        ];
-
-        if ($routing = $builder->getRouting()) {
-            $params['routing'] = $routing;
-        }
-
-        if ($parentId = $builder->getParentId()) {
-            $params['parent'] = $parentId;
-        }
-
-        return $params;
+        return $this->compileSelect($builder);
     }
 
     /**