Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solved undo deleted item - clean code #488
base: master
Are you sure you want to change the base?
Solved undo deleted item - clean code #488
Changes from all commits
95a7f5e
e318fad
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to use
ExecuteActionFromContextMenu
for this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an existing implementation of this - see
FileProgressSink
. That implementation could be updated to notify on deletes. That would simplify this code, since you wouldn't need to implement the entire class.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am affraid this is not possible, because
CFileOperationProgressSink
needs a custom constructor:in order to initialize
std::vector<PCIDLIST_ABSOLUTE> &m_vPidls;
which is a reference.
Because
FileProgressSink
is derived fromwinrt::implements<FileProgressSink, IFileOperationProgressSink, winrt::non_agile>
, I cannot implement that custom constructor:Error:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we derive
FileProgressSink
fromIFileOperationProgressSink
only?