chore: update dependencies (including circle -> gha) #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test run: https://github.com/dequelabs/dbjorge-test-repo/actions/runs/9604481533/job/26490058201
Notes on the updates:
NODE_ENV === 'test'
. The alternatives would be to use a beta version of nock (didn't want to use a beta version of anything in a repo we update so rarely) or to use a different mocking library (fetch-mock
was the best-looking option but it required more test changes than I wanted to spend time on to swap it out)I included a conversion from circle to GHA because I hit errors when naively updating the circle config to node 20 and it was faster to convert than to debug circle. None of the failed checks are relevant anymore; once this merges we can disable circle in this repo and update the branch policies to refer to GHA.
Reviewer checks
Required fields, to be filled out by PR reviewer(s)