-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ refactor: update user level batch refactoring #454
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seonghun-dev
added
😺 API Server
Api Domain
🏃🏽Batch Server
Batch Domain
and removed
😺 API Server
Api Domain
labels
Mar 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #454 +/- ##
============================================
+ Coverage 30.12% 30.58% +0.46%
Complexity 125 125
============================================
Files 77 76 -1
Lines 996 981 -15
Branches 32 31 -1
============================================
Hits 300 300
+ Misses 691 676 -15
Partials 5 5
|
seonghun-dev
commented
Mar 25, 2024
backend/streetdrop-batch/src/main/java/com/depromeet/domains/user/service/UserService.java
Show resolved
Hide resolved
siyeonSon
requested changes
Apr 3, 2024
backend/streetdrop-batch/src/main/java/com/depromeet/domains/level/LevelUpdater.java
Outdated
Show resolved
Hide resolved
...end/streetdrop-batch/src/main/java/com/depromeet/domains/item/repository/ItemRepository.java
Show resolved
Hide resolved
siyeonSon
reviewed
May 9, 2024
backend/streetdrop-batch/src/main/java/com/depromeet/domains/user/service/UserService.java
Outdated
Show resolved
Hide resolved
siyeonSon
reviewed
May 9, 2024
backend/streetdrop-batch/src/main/java/com/depromeet/domains/level/LevelUpdater.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.