✨ Add Report to Discord Channel #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yunyoung1819
commented
Oct 29, 2023
yunyoung1819
commented
- Resolve: Add Report to Discord Channel #386
seonghun-dev
requested changes
Oct 30, 2023
backend/streetdrop-api/src/main/java/com/depromeet/domains/item/service/ItemClaimService.java
Outdated
Show resolved
Hide resolved
backend/streetdrop-api/src/test/java/unit/domains/item/service/ItemClaimServiceTest.java
Outdated
Show resolved
Hide resolved
backend/streetdrop-api/src/main/java/com/depromeet/domains/item/service/ItemClaimService.java
Outdated
Show resolved
Hide resolved
backend/streetdrop-api/src/main/java/com/depromeet/domains/user/service/UserBlockService.java
Show resolved
Hide resolved
backend/streetdrop-api/src/main/java/com/depromeet/external/discord/DiscordService.java
Outdated
Show resolved
Hide resolved
| @RequiredArgsConstructor | ||
| public class DiscordService { | ||
|
|
||
| public void sendMessages(String webhookUrl, String content, String discordReportingChannel) { |
There was a problem hiding this comment.
webhookUrl 부분은 설정으로 빼도 좋을 것 같습니다
There was a problem hiding this comment.
음 혹시 설정으로 빼는 것이 프로퍼티로 뺴는거 인걸까요~?
아이템 신고하기와 사용자 차단이 webhook url 이 달라서 DiscordService에서 채널에 따라 url을 분기시키기보다 각각의 Report 서비스에서 webhookUrl을 프로퍼티에서 읽어와 DiscordService로 전달하도록 구현했습니당!
DiscordService에서 설정으로 빼면 채널별로 url 분기가 필요하지 않나여~?
There was a problem hiding this comment.
채널별로 url이 달라지는 군요
그럼 String discordReportingChannel 이 부분이 필요없어지겠군요
backend/streetdrop-api/src/main/java/com/depromeet/external/discord/DiscordService.java
Show resolved
Hide resolved
backend/streetdrop-api/src/main/java/com/depromeet/external/discord/DiscordWebhookPayload.java
Outdated
Show resolved
Hide resolved
...drop-api/src/main/java/com/depromeet/report/block/service/DiscordUserBlockReportService.java
Show resolved
Hide resolved
|
|
||
| import com.depromeet.report.block.dto.UserBlockReportDto; | ||
|
|
||
| public interface UserBlockReportService { |
There was a problem hiding this comment.
상위에서 인터페이스 사용이 안되는 것 같습니다
There was a problem hiding this comment.
아 DiscordUserBlockReportService implements UserBlockReportService로 사용하고 있는데 혹시 상위에서 인터페이스 사용이 안된다는건 어떤 부분 말씀이실까여~?
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #393 +/- ##
============================================
+ Coverage 28.84% 29.36% +0.51%
- Complexity 87 91 +4
============================================
Files 52 57 +5
Lines 676 722 +46
Branches 21 22 +1
============================================
+ Hits 195 212 +17
- Misses 479 508 +29
Partials 2 2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.