Skip to content

Commit

Permalink
♻️ refactor(domain): manage flyway scripts in api -> domain (#462)
Browse files Browse the repository at this point in the history
* ♻️ refactor(domain): manage flyway scripts in api -> domain

* 🔧 config(domain): move database settings to domain module

* 🔧 config: change the path of flyway scripts

* ♻️ refactor(api, batch): add mysql dependency
  • Loading branch information
siyeonSon authored and seonghun-dev committed May 8, 2024
1 parent 6f35c51 commit 0fc44c2
Show file tree
Hide file tree
Showing 13 changed files with 4 additions and 8 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/flyway-naming-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,11 @@ on:
push:
branches: [ "*" ]
paths:
- "backend/streetdrop-api/**"
- "backend/streetdrop-domain/**"
- "backend/streetdrop-common/**"
pull_request:
branches: [ "main", "dev" ]
paths:
- "backend/streetdrop-api/**"
- "backend/streetdrop-domain/**"
- "backend/streetdrop-common/**"
- ".github/workflows/flyway-naming-check.yml"
Expand All @@ -23,4 +21,4 @@ jobs:
- name: flyway-naming-checker
uses: seonghun-dev/[email protected]
with:
path: 'backend/streetdrop-api/src/main/resources/db/migration'
path: 'backend/streetdrop-domain/src/main/resources/db/migration'
3 changes: 0 additions & 3 deletions backend/streetdrop-api/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,6 @@ dependencies {

implementation 'org.springframework.boot:spring-boot-starter-webflux'
implementation 'io.awspring.cloud:spring-cloud-starter-aws:2.4.4'

implementation 'org.flywaydb:flyway-core'
implementation 'org.flywaydb:flyway-mysql'
}


Expand Down
2 changes: 0 additions & 2 deletions backend/streetdrop-batch/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ dependencies {
implementation 'org.springframework.boot:spring-boot-starter-security'

runtimeOnly 'com.mysql:mysql-connector-j'
implementation 'org.flywaydb:flyway-core'
implementation 'org.flywaydb:flyway-mysql'

implementation 'com.google.firebase:firebase-admin:9.1.0'

Expand Down
3 changes: 3 additions & 0 deletions backend/streetdrop-domain/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,7 @@ dependencies {
annotationProcessor "com.querydsl:querydsl-apt:5.0.0:jakarta"
annotationProcessor "jakarta.annotation:jakarta.annotation-api"
annotationProcessor "jakarta.persistence:jakarta.persistence-api"

implementation 'org.flywaydb:flyway-core'
implementation 'org.flywaydb:flyway-mysql'
}

0 comments on commit 0fc44c2

Please sign in to comment.