Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SAMBAD-242] 질문 답변 활성화 및 비활성화 플로우 이슈 픽스 #94

Merged
merged 3 commits into from
Aug 13, 2024
Merged

[SAMBAD-242] 질문 답변 활성화 및 비활성화 플로우 이슈 픽스 #94

merged 3 commits into from
Aug 13, 2024

Conversation

kkjsw17
Copy link
Collaborator

@kkjsw17 kkjsw17 commented Aug 12, 2024

✔️ PR 타입(하나 이상의 PR 타입을 선택해주세요)

  • 기능 추가
  • 버그 수정
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트
  • 기타 사소한 수정

📝 개요

  • 프로필 이미지가 4MB를 넘어갈 경우, 업로드에 실패하는 이슈를 수정합니다.
  • 모든 모임원이 답변했는지 검증할 시, 한 모임원이 선택한 답변 수만큼 모임원 수로써 산정되는 이슈를 수정합니다.
  • 모임장 가입 시, 모임 등록 이벤트가 등록되지 않는 이슈를 수정합니다.
  • 전체적으로 활성화 및 비활성화 질문 조회 시, 모든 모임원 답변 여부가 아닌 status 만으로 판별하도록 수정합니다.

🔗 ISSUE 링크

@kkjsw17 kkjsw17 requested review from nahyeon99 and LeeHanEum August 12, 2024 16:24
@kkjsw17 kkjsw17 self-assigned this Aug 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 12, 2024 •
edited
Loading

Unit Test Results

4 tests   4 ✔️  0s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 8e4fbc8.

♻️ This comment has been updated with latest results.

LeeHanEum
LeeHanEum approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@LeeHanEum LeeHanEum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

nahyeon99
nahyeon99 approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@nahyeon99 nahyeon99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구두로 리뷰 진행 완료했습니다!

@kkjsw17 kkjsw17 merged commit e733ad9 into develop Aug 13, 2024
2 checks passed
@kkjsw17 kkjsw17 deleted the fix/SAMBAD-242-fix_meeting_question_issue branch August 13, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeHanEum LeeHanEum LeeHanEum approved these changes

@nahyeon99 nahyeon99 nahyeon99 approved these changes

Assignees

@kkjsw17 kkjsw17

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kkjsw17 @nahyeon99 @LeeHanEum