Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SAMBAD-222] 모임 질문 조회 시 활성화, 비활성화 조건 버그 수정 #87

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

nahyeon99
Copy link
Member

✔️ PR 타입(하나 이상의 PR 타입을 선택해주세요)

  • 기능 추가
  • 버그 수정
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트
  • 기타 사소한 수정

📝 개요

  • 종료된 모임질문 조회 시, question 이 null 이 아닌 경우(질문이 등록된 경우)만 조회하도록 수정합니다.
  • 종료된 모임 질문 응답 시, 답변이 등록되지 않은 경우를 고려합니다.
  • 활성화된 모임 질문 조건에 질문 등록 여부를 고려합니다.

@nahyeon99 nahyeon99 requested review from kkjsw17 and LeeHanEum August 4, 2024 11:40
@nahyeon99 nahyeon99 self-assigned this Aug 4, 2024
Copy link

github-actions bot commented Aug 4, 2024

Unit Test Results

4 tests   4 ✔️  0s ⏱️
1 suites  0 💤
1 files    0

Results for commit 4d4f5e0.

Copy link
Collaborator

@kkjsw17 kkjsw17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다 👍

@nahyeon99 nahyeon99 merged commit 791bdf1 into develop Aug 5, 2024
2 checks passed
@nahyeon99 nahyeon99 deleted the feature/SAMBAD-222-fix_meeting_question_read_bug branch August 5, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants