Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SAMBAD-309]-손흔들기 수락 거절 시 event 비활성화 #150

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

LeeHanEum
Copy link
Member

@LeeHanEum LeeHanEum commented Aug 28, 2024

📍 [SAMBAD-309]-손흔들기 수락 거절 시 event 비활성화

✔️ PR 타입(하나 이상의 PR 타입을 선택해주세요)

  • 기능 추가
  • 버그 수정
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트
  • 기타 사소한 수정

📝 개요

  • 손흔들기 수락 거절 시 event 비활성화
  •   @Transactional
      public void acceptHandWaving(Long userId, Long meetingId, Long handWavingId) {
      	meetingMemberValidator.validateUserIsMemberOfMeeting(userId, meetingId);
      	HandWaving handWaving = getHandWavingById(handWavingId);
      	handWaving.validateIsReceiver(userId);
      	handWaving.accept();
      	eventService.inactivate(handWaving.getEventId());
      }

💡 코드 리뷰 시 참고 사항

  • 위 방법으로 할 경우 event 못찾으면 예외를 던집니다. 괜찮을까요?

🔗 ISSUE 링크

@LeeHanEum LeeHanEum self-assigned this Aug 28, 2024
@LeeHanEum LeeHanEum requested review from kkjsw17 and nahyeon99 August 28, 2024 06:32
Copy link

github-actions bot commented Aug 28, 2024

Unit Test Results

4 tests   4 ✔️  0s ⏱️
1 suites  0 💤
1 files    0

Results for commit 1a33bf2.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@kkjsw17 kkjsw17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~👍
eventId == null이면 inactive 호출 안하는 코드도 넣어주시면 될 것 같습니다.
아마 eventId 없으면 에러 뱉을거에요.

@LeeHanEum
Copy link
Member Author

뱉을거에요.

해당 내용 반영했습니다!

@kkjsw17
Copy link
Collaborator

kkjsw17 commented Aug 28, 2024

굿굿!

@LeeHanEum LeeHanEum merged commit 0010c12 into develop Aug 28, 2024
2 checks passed
@LeeHanEum LeeHanEum deleted the refactor/SAMBAD-309-handwaving-event-inactive branch August 28, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants