Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SAMBAD-309]- 손흔들기 수락 거절 시 이벤트 inactive #148

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

LeeHanEum
Copy link
Member

@LeeHanEum LeeHanEum commented Aug 28, 2024

📍 [SAMBAD-이슈번호] PR 제목

✔️ PR 타입(하나 이상의 PR 타입을 선택해주세요)

  • 기능 추가
  • 버그 수정
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트
  • 기타 사소한 수정

📝 개요

  • 손흔들기 수락 거절 시 이벤트 inactive
  @Transactional
  public void acceptHandWaving(Long userId, Long meetingId, Long handWavingId) {
  	meetingMemberValidator.validateUserIsMemberOfMeeting(userId, meetingId);
  	HandWaving handWaving = getHandWavingById(handWavingId);
  	handWaving.validateIsReceiver(userId);
  	handWaving.accept();
  	eventService.inactivateLastEventByType(userId, meetingId, HAND_WAVING_REQUESTED);
  }

🔗 ISSUE 링크

@LeeHanEum LeeHanEum requested review from kkjsw17 and nahyeon99 August 28, 2024 06:14
@LeeHanEum LeeHanEum self-assigned this Aug 28, 2024
Copy link

Unit Test Results

4 tests   4 ✔️  0s ⏱️
1 suites  0 💤
1 files    0

Results for commit 9c39048.

Copy link
Member

@nahyeon99 nahyeon99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@LeeHanEum LeeHanEum merged commit 825e267 into develop Aug 28, 2024
2 checks passed
@LeeHanEum LeeHanEum deleted the refactor/SAMBAD-309-handwaving-event-inactive branch August 28, 2024 06:19
@kkjsw17
Copy link
Collaborator

kkjsw17 commented Aug 28, 2024

노노노노 EventService#inactivate 쓰셔야 해요.
handWaving.eventId 인자로 넘겨주시면 됩니다.

eventService.inactivateLastEventByType(userId, meetingId, HAND_WAVING_REQUESTED);
이거 쓰면, 어떤 콕찌르기 이벤트를 비활성화 하는건지 특정이 안돼요.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants