Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SAMBAD-301] 손 흔들기 알림 추가 정보 제공 방식 변경 #140

Merged

Conversation

kkjsw17
Copy link
Collaborator

@kkjsw17 kkjsw17 commented Aug 26, 2024

✔️ PR 타입(하나 이상의 PR 타입을 선택해주세요)

  • 기능 추가
  • 버그 수정
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트
  • 기타 사소한 수정

📝 개요

  • 기존 event.additional_filed를 삭제합니다.
  • hand_waving.event_id 필드를 추가합니다.
    • 이벤트 조회 시 HAND_WAVING_REQUESTED 타입이면, hand_waving 엔티티를 가져와 추가 정보를 매핑해줍니다.

🔗 ISSUE 링크

@kkjsw17 kkjsw17 requested review from nahyeon99 and LeeHanEum August 26, 2024 00:25
@kkjsw17 kkjsw17 self-assigned this Aug 26, 2024
Copy link

Unit Test Results

4 tests   4 ✔️  0s ⏱️
1 suites  0 💤
1 files    0

Results for commit 692c79f.

Copy link
Member

@nahyeon99 nahyeon99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkjsw17 kkjsw17 merged commit a5dd742 into develop Aug 26, 2024
2 checks passed
@kkjsw17 kkjsw17 deleted the feature/SAMBAD-301-remove_additional_data_column_in_event branch August 26, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants