[SAMBAD-258] release/1.0.0-beta.4 rebase 업데이트 #110
Closed
+168
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: 종료된 모임 질문의 경우 참여율 계산 로직 수정 * fix: 계산 메서드 로직 오류 수정 * refactor: 비활성화된 질문의 비활성화 시도 시 대응 코드 추가 * fix: 질문 개수 범위 오류 수정 * refactor: 전체 모임원 수 null 비허용하도록 수정
* [SAMBAD-254]-feat: Poking 엔티티 작성 * [SAMBAD-254]-feat: Poking controller service repository 추가 * [SAMBAD-254]-refactor: poking에서 handWaving으로 변경
kkjsw17
reviewed
Aug 19, 2024
여기서 SAMBAD-255 커밋만 develop에 머지가 되어야 하는 상태이고, |
|
@kkjsw17 혹시 몰라서 다시 작업해봤는데, 여전히 2개 커밋 들어가게 되네요 ㅠㅠ 제가 어떤 부분을 놓쳤을까요? 
|
이따 게더에서 같이 확인해봅시당 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✔️ PR 타입(하나 이상의 PR 타입을 선택해주세요)
📝 개요