Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 멤버 추가 시 출석 init 하도록 추가 #77

Merged
merged 2 commits into from
May 28, 2024
Merged

feat: 멤버 추가 시 출석 init 하도록 추가 #77

merged 2 commits into from
May 28, 2024

Conversation

ddingmin
Copy link
Member

💡 기능

  • 멤버 추가 시 출석 데이터들을 init 하도록 추가했습니다.
  • 기존에 CheckIn 헬스 체크에 존재하던 default 출석 데이터 생성 로직을 제거했습니다.

🔎 기타

  • 세션 생성이 우선시 되어야 합니다.
    • 생성된 세션을 기반으로 유저의 출석 정보를 생성합니다.
  • ❗️기존 유저의 경우에도 잘 타는지 확인 부탁드려요!

@ddingmin ddingmin requested a review from CChuYong as a code owner May 27, 2024 14:49
CChuYong
CChuYong approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@CChuYong CChuYong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨슴다!

src/main/kotlin/com/depromeet/makers/domain/usecase/CreateNewMember.kt Outdated
@@ -46,6 +51,20 @@ class CreateNewMember(
initialGeneration = newGeneration,
)
}
initializeAttendance(newMember, newGeneration.generationId)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Member persist 이전에 실행되는거에 문제는 따로 없나용??
(실제로 member 없이 얘만 생성된다거나 혹은 서로 fk로 엮여있다거나)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안전하게 가려면 순서가 바뀌는게 맞겠네요!

@ddingmin ddingmin merged commit a38b09e into depromeet:develop May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CChuYong CChuYong CChuYong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddingmin @CChuYong