Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 세션 불참자 결석 처리 스케쥴러 구현 #41

Merged
merged 2 commits into from
May 20, 2024
Merged

feat: 세션 불참자 결석 처리 스케쥴러 구현 #41

merged 2 commits into from
May 20, 2024

Conversation

ddingmin
Copy link
Member

@ddingmin ddingmin commented May 19, 2024 •
edited
Loading

💡 기능

  • 매주 토요일 20시 기점으로 해당 일자의 세션이 존재할 때, 출석 대기 상태의 멤버들의 출석 상태를 결석으로 변경합니다.

🔎 기타

  • 추가적으로 로깅이 필요한 부분이 있을지 의견주세요!
  • 스케쥴러 첨 구현해봤는데 문제 없는지도 한번 확인해주세용(테스트해 볼 방법이 없어성..) 🫡

Close #40

@ddingmin ddingmin requested a review from CChuYong as a code owner May 19, 2024 16:38
@github-actions GitHub Actions
Copy link

Auto labels applied based on the title of the PR.

CChuYong
CChuYong reviewed May 19, 2024
View reviewed changes
src/main/kotlin/com/depromeet/makers/scheduler/AbsentMemberScheduler.kt Outdated
) {

@Scheduled(cron = "0 0 20 ? * SAT")
fun scheduling() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요거 약간 함수명이 조금 더 명확하게 (updateAbsenceMember 거나.. 약간 그런느낌..?) 이면 좋을 것 같아요

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CChuYong 반영했습니다~ 스케쥴러 패키지 위치도 문제 없는지만 확인 해주세요!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 것 같슴다~!

CChuYong
CChuYong approved these changes May 19, 2024
View reviewed changes
Copy link
Member

@CChuYong CChuYong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@CChuYong CChuYong merged commit abf79ff into develop May 20, 2024
@CChuYong CChuYong deleted the feature/#41 branch May 20, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CChuYong CChuYong CChuYong approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: 세션 불참자 결석 처리 스케쥴러 구현
2 participants
@ddingmin @CChuYong