feat: 시간 기록 기능을 구현합니다. #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wokbjso
requested review from
hjy0951,
Jungjjeong and
summermong
as code owners
Jungjjeong
approved these changes
Aug 2, 2024
| }, | ||
| }} | ||
| > | ||
| <div className={layout.bottomSheet}> |
There was a problem hiding this comment.
시연 영상을 보았을 때, 바텀시트는 따로 올라오고 요 피커는 먼저 올라와있는 것 같아요.
혹시 요 부분 해소가 어려울까요..?
There was a problem hiding this comment.
저도 인지하고 있는데 빠른시간내에 처리가 어려울 것 같아서 우선은 남겨두었습니다...ㅎ
모든 api 연결 테스트 후 이런 세세한 부분들 수정해 나갈 예정입니다!
|
|
||
| import { useEffect, useState } from 'react'; | ||
|
|
||
| export default function useGetBrowserWidth() { |
There was a problem hiding this comment.
👍
저희는 최대 너비가 600px이기 때문에, 요 부분도 예외처리 해주면 좋을 것 같습니다!
| @@ -0,0 +1,3 @@ | |||
| .custom-picker input { | |||
| visibility: hidden; | |||
| } | |||
There was a problem hiding this comment.
요 스타일을 custom picker 컴포넌트 내부 선택자로 넣어줄 수는 없을까요?
There was a problem hiding this comment.
저도 그게 좋다고 생각하는데 Panda에서 어떻게 넣어줘야 할지 아직 알아보지 못해서 우선 위처럼 처리했습니다 ㅎㅎ
저 부분 더 알아보고 수정할 수 있다면 수정해 놓겠습니다!!
혹시 문법 알고 계시면 알려주시면 감사하겠습니다~~
There was a problem hiding this comment.
윤님 코드 보니까 요런 식으로 넣을 수 있을 것 같아요!! 💪🏻
| value="18:30" | ||
| value={ | ||
| methods.watch('startTime') ? methods.watch('startTime') : '' | ||
| } |
There was a problem hiding this comment.
성능에는 미미한 영향을 미치겠지만.. watch를 한번만 호출하는 것이 좋을 것 같아요.
const startTime = methods.watch('startTime');
value={startTime || ''}
king2dwellsang
added
Approved 🆗
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 어떤 문제가 발생했나요?
🎉 어떻게 해결했나요?
📷 이미지 첨부 (Option)
default.mp4