feat: 세부 기록(심박수, 페이스, 칼로리) 작성 구현합니다. #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-Team2-Web into feat/record-sub-info
…15th-Team2-Web into feat/record-sub-info
king2dwellsang
added
feat
Jungjjeong
approved these changes
Aug 2, 2024
| @@ -30,6 +30,7 @@ interface SubInfoProps { | |||
| } | |||
|
|
|||
| //Todo: null 타입 제거 | |||
| //Todo: watch의 성능 이슈 고민 | |||
king2dwellsang
added
Approved 🆗
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 어떤 문제가 발생했나요?
🎉 어떻게 해결했나요?
📷 이미지 첨부 (Option)
default.mp4
우선 다른 부분들과 통일되게 일단은 setValue를 사용하였는데, 해당 필드들은 직접 값을 입력할 수 있어서 register 사용이 가능하긴 할 것 같습니다. 우선 register를 활용하려면 text-field 컴포넌트를 수정해야해서 아직 진행하지는 않았고, setValue보다 register 사용이 성능상 더 낫다면 추후 리팩토링 진행 할 예정입니다.
또한 준영님께서 예전에 watch 메소드를 사용 시 많은 리렌더링 issue가 발생한 경험을 공유해주셨는데, 저도 한번 알아보고 시간날 때 현재 watch를 사용하고 있는 부분들 중 수정할 수 있는 부분들은 수정해 나가려고 합니다!