Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 사진 기록 section을 구현합니다. #69

Merged
merged 13 commits into from
Aug 2, 2024

Conversation

wokbjso
Copy link
Member

@wokbjso wokbjso commented Jul 31, 2024

🤔 어떤 문제가 발생했나요?

🎉 어떻게 해결했나요?

  • 사진을 올릴 수 있는 사진 기록 section 관련 기능들을 구현하였습니다.

📷 이미지 첨부 (Option)

default.mp4

⚠️ 유의할 점! (Option)

  • NA

@king2dwellsang king2dwellsang added Review Plz🙏 # Review is not yet complete feat # Add feature labels Jul 31, 2024
Copy link
Member

@Jungjjeong Jungjjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

}
};
uploadImage().catch((error) =>
console.error('이미지 업로드 중 오류가 발생하였습니다', error),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요 부분 기획에 여쭤보고 dialog로 띄워주면 좋을 것 같습니다.

api 에러, 동작 에러 등등의 대한 예외처리가 한번에 필요할 것 같아요

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 피그마에 코멘트 남긴 후 확인하고 띄워주겠습니다~~

@king2dwellsang king2dwellsang added Approved 🆗 # Review is completed and removed Review Plz🙏 # Review is not yet complete labels Aug 2, 2024
@wokbjso wokbjso merged commit 48a9031 into feat/distance-record-logic Aug 2, 2024
2 checks passed
@wokbjso wokbjso deleted the feat/record-photo branch August 2, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved 🆗 # Review is completed feat # Add feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants