Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dialog component storybook 파일을 작성합니다 #60

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

Jungjjeong
Copy link
Member

🤔 어떤 문제가 발생했나요?

🎉 어떻게 해결했나요?

  • dialog component storybook 파일을 작성합니다.

📷 이미지 첨부 (Option)

스크린샷 2024-07-28 오후 7 06 54

⚠️ 유의할 점! (Option)

@Jungjjeong Jungjjeong changed the base branch from main to feat/storybook-bottomsheet July 28, 2024 10:07
@king2dwellsang king2dwellsang added the Review Plz🙏 # Review is not yet complete label Jul 28, 2024
@king2dwellsang king2dwellsang added the feat # Add feature label Jul 28, 2024
Copy link
Collaborator

@hjy0951 hjy0951 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스토리북 때문에 고생 많으셨습니다 ㅠ

Comment on lines -13 to +11
<div className={css({ minHeight: 500 })}>
<div style={{ minHeight: 500 }}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅠㅠㅠ 갑자기 또 안먹는 스토리북...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그래서 다급하게 css import 빼버린 나..

@king2dwellsang king2dwellsang added Approved 🆗 # Review is completed and removed Review Plz🙏 # Review is not yet complete labels Jul 29, 2024
@Jungjjeong Jungjjeong merged commit 46ef416 into feat/storybook-bottomsheet Jul 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved 🆗 # Review is completed feat # Add feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants