Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: style 폴더 한개로 통합 #31

Merged
merged 3 commits into from
Jul 22, 2024
Merged

chore: style 폴더 한개로 통합 #31

merged 3 commits into from
Jul 22, 2024

Conversation

wokbjso
Copy link
Member

@wokbjso wokbjso commented Jul 21, 2024 •
edited
Loading

🤔 어떤 문제가 발생했나요?

  • 초기 세팅에 들어간 app 폴더 내부의 style 폴더 & 루트 경로의 style 폴더 2개가 존재합니다.

🎉 어떻게 해결했나요?

  • app 폴더 내부의 style 폴더를 루트 경로로 뺀 후 통합하였습니다.
  • 경로 이동에 따른 내부 import 경로 수정
  • panda.config.js 파일에 직접적으로 선언되어 있단 colors, shadows 관련 정보들을 styles 폴더에 정리

📷 이미지 첨부 (Option)

  • NA

⚠️ 유의할 점! (Option)

  • NA

@king2dwellsang king2dwellsang added chore # Chores style # Style code (code formatting) Review Plz🙏 # Review is not yet complete labels Jul 21, 2024
hjy0951
hjy0951 approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@hjy0951 hjy0951 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안그래도 panda.config.ts 파일이 너무 커질것 같아서 말씀드리려했는데 딱 분리해주셨네요!

좋습니다! 💯👍

@king2dwellsang king2dwellsang added Approved 🆗 # Review is completed and removed Review Plz🙏 # Review is not yet complete labels Jul 22, 2024
Jungjjeong
Jungjjeong approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@Jungjjeong Jungjjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

wokbjso added 2 commits July 23, 2024 00:17
@wokbjso
feat: text-field 컴포넌트 생성
d0fc9c5 
* feat: text-field 컴포넌트 생성

* chore: text-field 컴포넌트 관리 폴더 이름 수정

* Update index.ts

* chore: 외부 스타일 주입 로직 수정

* feat: header-bar 컴포넌트 생성

* feat: header-bar 컴포넌트 생성

* fix: 화살표 icon에 absolute 속성 부여

* refactor: header-bar 컴포넌트 구조 수정

* chore: header-bar 컴포넌트 molecule로 변경

* refactor: 코드 리뷰 반영
@wokbjso
Merge branch 'main' into chore/style-setting
25f04c3
@wokbjso wokbjso merged commit b6511c1 into main Jul 22, 2024
1 of 2 checks passed
@wokbjso wokbjso deleted the chore/style-setting branch July 22, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jungjjeong Jungjjeong Jungjjeong approved these changes

@hjy0951 hjy0951 hjy0951 approved these changes

@summermong summermong Awaiting requested review from summermong summermong is a code owner

Assignees

@wokbjso wokbjso

Labels
Approved 🆗 # Review is completed chore # Chores style # Style code (code formatting)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wokbjso @hjy0951 @Jungjjeong @king2dwellsang