feat: 탈퇴 기능을 구현합니다. #293
Merged
feat: 탈퇴 기능을 구현합니다. #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
summermong
requested review from
hjy0951,
Jungjjeong and
wokbjso
as code owners
hjy0951
approved these changes
Aug 29, 2024
features/setting/types/delete.ts
Outdated
Comment on lines
1
to
6
| export interface DeleteAccountProps { | ||
| status: number; | ||
| code: string; | ||
| message: string; | ||
| data: object; | ||
| } |
There was a problem hiding this comment.
음 개인적으로 응답인데 Props라는 네이밍보다는 Response가 좋아보이고, 현민님께서 작성해주신 Response type을 활용하면 더 깔끔할 것 같습니다!
king2dwellsang
added
Approved 🆗
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 어떤 문제가 발생했나요?
🎉 어떻게 해결했나요?
📷 이미지 첨부 (Option)
2024-08-29.10.44.38.mov