Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 수영 거리 기록 버그 수정 #289

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Conversation

wokbjso
Copy link
Member

@wokbjso wokbjso commented Aug 29, 2024

🤔 어떤 문제가 발생했나요?

  • 전달되지 않은 props가 있었습니다.

  • 예를 들어 영법별 기록의 바퀴 수를 4개 입력했던 기록에서 -> 영법별 기록의 미터 수를 3개 입력으로 수정 후 -> 다시 수정 페이지로 접근하여 보면 처음의 바퀴 수 기록이 일부 남아있는 버그가 있었습니다.

🎉 어떻게 해결했나요?

  • props를 전달해주었습니다

  • gcTime을 0으로 설정해주어 캐시된 데이터가 미리 보여짐으로써 useEffect가 두번 실행되는 현상을 수정하였습니다.

📷 이미지 첨부 (Option)

  • NA

⚠️ 유의할 점! (Option)

  • NA

@king2dwellsang king2dwellsang added the Review Plz🙏 # Review is not yet complete label Aug 29, 2024
@king2dwellsang king2dwellsang added the fix # Fix bug label Aug 29, 2024
Copy link
Collaborator

@summermong summermong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@king2dwellsang king2dwellsang added Approved 🆗 # Review is completed and removed Review Plz🙏 # Review is not yet complete labels Aug 29, 2024
@wokbjso wokbjso merged commit b09db1d into main Aug 29, 2024
7 of 8 checks passed
@wokbjso wokbjso deleted the fix/distance-page-modal branch August 29, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved 🆗 # Review is completed fix # Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants