feat: 소식 페이지 헤더중 팔로잉 목록 이동 버튼을 위한 API 추가 #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjy0951
requested review from
Jungjjeong,
wokbjso and
summermong
as code owners
hjy0951
changed the title
Jungjjeong
approved these changes
Aug 28, 2024
| const hasFollowings = followingCount > 0; | ||
| const indexOffset = MAX_NUMBER_OF_PROFILES - followings.length; | ||
| let nodeList: Array<ReactNode> = []; | ||
|
|
||
| if (hasFollowings) { | ||
| nodeList = followings.map(({ memberId, profileUrl }, index) => ( | ||
| nodeList = followings.map(({ memberId, profileImageUrl }, index) => ( |
There was a problem hiding this comment.
followings.map으로도 충분히 반복문을 돌 수 있을 것 같은데 nodeList를 let으로 선언해서 사용하시는 이유가 있을까요?
There was a problem hiding this comment.
엇 단순히 followings 길이가 1 이상일 경우, map을 이용해 요소들의 배열을 만들어 nodeList에 넣어줘야겠다는 생각으로 작성했던 것 같습니다!
const nodeList = [...followings.map(...)];혹시 const 선언 이후 위와 같은 방식을 말씀하시려던 걸까요?!
king2dwellsang
added
Approved 🆗
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 어떤 문제가 발생했나요?
🎉 어떻게 해결했나요?
📷 이미지 첨부 (Option)