refactor: 마크업 수정 및 기존 코드를 배열로 리팩토링했습니다. #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
summermong
requested review from
hjy0951,
Jungjjeong and
wokbjso
as code owners
Jungjjeong
approved these changes
Aug 28, 2024
app/setting/page.tsx
Outdated
| const containerStyles = css({ | ||
| display: 'flex', | ||
| flexDirection: 'column', | ||
| minHeight: '100vh', |
There was a problem hiding this comment.
Suggested change
| minHeight: '100vh', | |
| minHeight: '100dvh', |
사파리 대응한 스타일 수정입니다
king2dwellsang
added
Approved 🆗
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 어떤 문제가 발생했나요?
🎉 어떻게 해결했나요?
📷 이미지 첨부 (Option)
2024-08-28.5.53.44.mov
setting 페이지만 봐주세용~