Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 회원가입 완료 페이지를 작업합니다. #268

Merged
merged 4 commits into from
Aug 28, 2024
Merged

feat: 회원가입 완료 페이지를 작업합니다. #268

merged 4 commits into from
Aug 28, 2024

Conversation

summermong
Copy link
Collaborator

🤔 어떤 문제가 발생했나요?

  • 피그마에서 회원가입 완료 페이지가 추가되었습니다.

🎉 어떻게 해결했나요?

  • 회원가입 과정을 거치면 /join/finish를 거쳐 /으로 이동할 수 있게 했습니다.

📷 이미지 첨부 (Option)

2024-08-28.5.24.04.mov

⚠️ 유의할 점! (Option)

  • QA 페이지에 적은 것처럼 추후 라우팅 관련해서 디테일한 옵션이 필요합니다.
  • figma에는 없어서 아직 넣지 않았지만 애니메이션이나 isLoading 시 버튼에 loadingIcon을 넣는 등 디테일한 ui가 필요할 것 같습니다.

@summermong summermong added the feat # Add feature label Aug 28, 2024
@king2dwellsang king2dwellsang added the Review Plz🙏 # Review is not yet complete label Aug 28, 2024
hjy0951
hjy0951 approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@hjy0951 hjy0951 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이미지 배경만 transparent로 바뀌면 머지해도 좋아보입니다~

@king2dwellsang king2dwellsang added Approved 🆗 # Review is completed and removed Review Plz🙏 # Review is not yet complete labels Aug 28, 2024
@summermong summermong merged commit 9f6b3cb into main Aug 28, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjy0951 hjy0951 hjy0951 approved these changes

@Jungjjeong Jungjjeong Awaiting requested review from Jungjjeong Jungjjeong is a code owner

@wokbjso wokbjso Awaiting requested review from wokbjso wokbjso is a code owner

Assignees

@summermong summermong

Labels
Approved 🆗 # Review is completed feat # Add feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@summermong @hjy0951 @king2dwellsang