Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: follow tab query change event 변경 #267

Merged
merged 1 commit into from
Aug 28, 2024
Merged

feat: follow tab query change event 변경 #267

merged 1 commit into from
Aug 28, 2024

Conversation

Jungjjeong
Copy link
Member

🤔 어떤 문제가 발생했나요?

  • history stack이 계속 쌓입니다.

🎉 어떻게 해결했나요?

  • push > replace event로 변경합니다

📷 이미지 첨부 (Option)

⚠️ 유의할 점! (Option)

@king2dwellsang king2dwellsang added Review Plz🙏 # Review is not yet complete feat # Add feature labels Aug 28, 2024
hjy0951
hjy0951 approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@hjy0951 hjy0951 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@king2dwellsang king2dwellsang added Approved 🆗 # Review is completed and removed Review Plz🙏 # Review is not yet complete labels Aug 28, 2024
@Jungjjeong Jungjjeong merged commit e8dfdc1 into main Aug 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjy0951 hjy0951 hjy0951 approved these changes

@wokbjso wokbjso Awaiting requested review from wokbjso wokbjso is a code owner

@summermong summermong Awaiting requested review from summermong summermong is a code owner

Assignees

@Jungjjeong Jungjjeong

Labels
Approved 🆗 # Review is completed feat # Add feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jungjjeong @hjy0951 @king2dwellsang