fix: 무한 설정 페이지 버그 수정합니다. #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
summermong
requested review from
hjy0951,
Jungjjeong and
wokbjso
as code owners
…to feat/profile
Jungjjeong
approved these changes
Aug 28, 2024
| @@ -48,7 +48,7 @@ export default function Page() { | |||
| <div> | |||
| <HeaderBar> | |||
| <HeaderBar.LeftContent> | |||
| <BackButton onClickBack={() => router.back()} /> | |||
| <BackButton onClickBack={() => router.push('/')} /> | |||
There was a problem hiding this comment.
기록 시각화 기준 거리 수정 후, 설정 페이지로 이동할 때 이벤트를 replace로 바꿔주시는건 어떨까요?
- 홈 > 설정 > push > 기록 시각화 기준 거리 > replace > 설정
- 결국은 홈 > 설정 > 설정의 히스토리만 남게 됩니다. (기록 시각화 기준 거리는 대체됩니다)
기록 상세에서도 동일한 흐름을 가져가고 있는데요, 요 방법으로 우선 적용해놓고 페이지 중복 문제는 한번에 해결해보시죠!
There was a problem hiding this comment.
혹은 기준 거리 수정 후 > 뒤로가기 해도 괜찮겠네요!
There was a problem hiding this comment.
@Jungjjeong 좋은 의견 감사합니닷!!! 🙇🏻
king2dwellsang
added
Approved 🆗
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 어떤 문제가 발생했나요?
🎉 어떻게 해결했나요?
📷 이미지 첨부 (Option)