Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: no-floating-promises lint error 수정 #261

Merged
merged 1 commit into from
Aug 27, 2024
Merged

fix: no-floating-promises lint error 수정 #261

merged 1 commit into from
Aug 27, 2024

Conversation

hjy0951
Copy link
Collaborator

@hjy0951 hjy0951 commented Aug 27, 2024

🤔 어떤 문제가 발생했나요?

  • no-floating-promises 에러가 갑자기 발생하였습니다.

🎉 어떻게 해결했나요?

  • Promise를 다루는 함수 앞에 void를 붙여 해결하였습니다.

📷 이미지 첨부 (Option)

스크린샷 2024-08-28 오전 1 26 00

⚠️ 유의할 점! (Option)

@king2dwellsang king2dwellsang added the Review Plz🙏 # Review is not yet complete label Aug 27, 2024
@king2dwellsang king2dwellsang added the fix # Fix bug label Aug 27, 2024
Jungjjeong
Jungjjeong approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@Jungjjeong Jungjjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@king2dwellsang king2dwellsang added Approved 🆗 # Review is completed and removed Review Plz🙏 # Review is not yet complete labels Aug 27, 2024
@hjy0951 hjy0951 merged commit ce94457 into main Aug 27, 2024
5 checks passed
@hjy0951 hjy0951 deleted the fix/no-floating-promises-in-news-list branch August 27, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jungjjeong Jungjjeong Jungjjeong approved these changes

@wokbjso wokbjso Awaiting requested review from wokbjso wokbjso is a code owner

@summermong summermong Awaiting requested review from summermong summermong is a code owner

Assignees

@hjy0951 hjy0951

Labels
Approved 🆗 # Review is completed fix # Fix bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hjy0951 @Jungjjeong @king2dwellsang