Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 헤더바 설정 아이콘 라우팅 추가 및 기존 아이콘 변경했습니다. #260

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

summermong
Copy link
Collaborator

@summermong summermong commented Aug 27, 2024

🤔 어떤 문제가 발생했나요?

  • 헤더바에 setting 아이콘 클릭 시 라우팅이 필요했습니다.

🎉 어떻게 해결했나요?

  • main header와 profile header에 적용했습니다.

📷 이미지 첨부 (Option)

2024-08-28.1.24.23.mov

⚠️ 유의할 점! (Option)

  • 영상 찍으면서 알았는데 이거 마이페이지로 갈 때 loadingArea가 또 나오네용... 추후 수정해야겠습니다!!

@summermong summermong added the feat # Add feature label Aug 27, 2024
@king2dwellsang king2dwellsang added the Review Plz🙏 # Review is not yet complete label Aug 27, 2024
Copy link
Member

@Jungjjeong Jungjjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

import {
BackButton,
GlobalNavigationBar,
HeaderBar,
} from '@/components/molecules';
import { SettingButton } from '@/components/molecules/header-bar/header-bar-setting-button';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { SettingButton } from '@/components/molecules/header-bar/header-bar-setting-button';
import { SettingButton } from '@/components/molecules';

SettingButton 베럴파일에 추가해주세용!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

음마야 ㅠㅠ

@king2dwellsang king2dwellsang added Approved 🆗 # Review is completed and removed Review Plz🙏 # Review is not yet complete labels Aug 27, 2024
Copy link
Collaborator

@hjy0951 hjy0951 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@summermong summermong merged commit 95e367f into main Aug 27, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved 🆗 # Review is completed feat # Add feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants