Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: follower, following list 마크업 및 데이터 연동 #251

Merged
merged 6 commits into from
Aug 27, 2024

Conversation

Jungjjeong
Copy link
Member

🤔 어떤 문제가 발생했나요?

🎉 어떻게 해결했나요?

  • 팔로워, 팔로잉 리스트 마크업 및 데이터 연동 작업입니다

📷 이미지 첨부 (Option)

⚠️ 유의할 점! (Option)

@king2dwellsang king2dwellsang added the Review Plz🙏 # Review is not yet complete label Aug 27, 2024
@king2dwellsang king2dwellsang added the feat # Add feature label Aug 27, 2024
Copy link
Member

@wokbjso wokbjso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🔥

@king2dwellsang king2dwellsang added Approved 🆗 # Review is completed and removed Review Plz🙏 # Review is not yet complete labels Aug 27, 2024
}: FollowVirtualList) => {
const handleRangeChanged = (range: { endIndex: number }) => {
const currentContentsLastIndex = data.length - 1;
if (range.endIndex >= currentContentsLastIndex - 3) {
Copy link
Collaborator

@summermong summermong Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

근데 왜 이거 -3 까지예요? (궁 금 궁 금)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그냥 제가 정한 기준이긴 해요
뷰포트 기준으로 overscan 500px + end index 3개 전에 다음 데이터 불러오는 조건입니다!

@Jungjjeong Jungjjeong merged commit 98c9c2f into feature/profile-api Aug 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved 🆗 # Review is completed feat # Add feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants