fix: 기록 생성 or 수정에서 이미 한번 버튼을 눌렀다면 다시 눌렀을 때 api 요청 막음 처리 #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wokbjso
requested review from
hjy0951,
Jungjjeong and
summermong
as code owners
Jungjjeong
approved these changes
Aug 26, 2024
| @@ -144,6 +144,7 @@ export function Form() { | |||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | |||
| const { poolName, laneMeter, totalDistance, ...restData } = data; | |||
| const submitData = modifySubmitData(restData); | |||
| if (isLoading) return; | |||
There was a problem hiding this comment.
onSubmit 이벤트 최상위에 넣어주면 좋을 것 같습니다.
추가로 버튼 loading 상태일 때 button을 disabled 시켜주는 처리도 필요할 것 같아요!
king2dwellsang
added
Approved 🆗
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 어떤 문제가 발생했나요?
🎉 어떻게 해결했나요?
📷 이미지 첨부 (Option)