Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Chromatic을 사용한 storybook 배포 및 GitHub Actions을 통한 자동 배포 #22

Merged
merged 6 commits into from
Jul 13, 2024
Merged

chore: Chromatic을 사용한 storybook 배포 및 GitHub Actions을 통한 자동 배포 #22

merged 6 commits into from
Jul 13, 2024

Conversation

hjy0951
Copy link
Collaborator

@hjy0951 hjy0951 commented Jul 11, 2024 •
edited
Loading

🤔 어떤 문제가 발생했나요?

  • 디자이너들과 원만한 협업을 위한 도구가 부족하였습니다.
  • ESLint와 typescript-eslint 사이에서 버전 의존성이 맞지 않았습니다.

🎉 어떻게 해결했나요?

  • Storybook 설치 및 Chromatic을 활용한 배포
  • GitHub Workflow를 활용하여 PR 등록시 story 파일에 변경점이 있다면 자동 배포
  • 요구 사항에 맞는 ESLint 버전 설치

📷 이미지 첨부 (Option)

  • ESLint 버전 관련
스크린샷 2024-07-11 오후 3 36 03
  • Action workflow 중 캐싱을 이용해 dependency 변화가 없을때에는 pnpm install을 하지 않도록 설정하였는데, 캐시 후처리에 시간이 많이 걸리고 실제 의존성 설치에는 시간이 너무 적게 걸려서 앞으로도 개선되는 요소가 보이지 않는다면 빼겠습니다!
스크린샷 2024-07-11 오후 5 31 40

⚠️ 유의할 점! (Option)

  • NA

@king2dwellsang king2dwellsang added the Review Plz🙏 # Review is not yet complete label Jul 11, 2024
@king2dwellsang king2dwellsang added the chore # Chores label Jul 11, 2024
@github-actions GitHub Actions
Copy link

🚀storybook: https://668f732cef9e25b9abbd3fc6-anzvbsapnd.chromatic.com/

@hjy0951 hjy0951 marked this pull request as ready for review July 11, 2024 08:27
@king2dwellsang king2dwellsang added Approved 🆗 # Review is completed and removed Review Plz🙏 # Review is not yet complete labels Jul 13, 2024
wokbjso
wokbjso reviewed Jul 13, 2024
View reviewed changes
Copy link
Member

@wokbjso wokbjso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍👍

@hjy0951 hjy0951 merged commit 81d7190 into main Jul 13, 2024
10 checks passed
@hjy0951 hjy0951 deleted the chore/deploy-storybook branch July 13, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wokbjso wokbjso wokbjso approved these changes

@Jungjjeong Jungjjeong Awaiting requested review from Jungjjeong Jungjjeong is a code owner

@summermong summermong Awaiting requested review from summermong summermong is a code owner

Assignees

@hjy0951 hjy0951

Labels
Approved 🆗 # Review is completed chore # Chores
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hjy0951 @wokbjso @king2dwellsang