chore: 코드 리뷰 반영

depromeet · Nov 26, 2024 · bbb1da4 · bbb1da4
1 parent c01dc4b
commit bbb1da4
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 27 deletions.
diff --git a/features/profile-recommend/components/molecules/recommended-profile-card.tsx b/features/profile-recommend/components/molecules/recommended-profile-card.tsx
@@ -51,27 +51,14 @@ export function RecommendedProfileCard({
       </Link>
       <div className={css(ProfileCardStyle.followButton.raw({ variant }))}>
         {!isMyProfile && (
-          <>
-            {isFollowing ? (
-              <Button
-                size="small"
-                label="팔로잉"
-                variant="outlined"
-                buttonType="assistive"
-                className={css({ w: 'full' })}
-                onClick={handleClickFollow}
-              />
-            ) : (
-              <Button
-                size="small"
-                label="팔로우"
-                variant="outlined"
-                buttonType="primary"
-                className={css({ w: 'full' })}
-                onClick={handleClickFollow}
-              />
-            )}
-          </>
+          <Button
+            size="small"
+            label={isFollowing ? '팔로잉' : '팔로우'}
+            variant="outlined"
+            buttonType={isFollowing ? 'assistive' : 'primary'}
+            className={css({ w: 'full' })}
+            onClick={handleClickFollow}
+          />
         )}
       </div>
     </div>

diff --git a/features/profile-recommend/components/molecules/recommended-profile-item.tsx b/features/profile-recommend/components/molecules/recommended-profile-item.tsx
@@ -12,11 +12,7 @@ export function RecommendedProfileItem({
   const { data: myData } = useCurrentMemberInfo();
   const { data: profileData } = useProfileData(memberId);
 
-  const getIsMyProfile = (memberId: number) => {
-    if (!myData?.data) return false;
-    const myMemberId = myData?.data.id;
-    return myMemberId === memberId;
-  };
+  const getIsMyProfile = myData?.data?.id === memberId;
 
   if (!profileData) return null;
   return (
@@ -25,7 +21,7 @@ export function RecommendedProfileItem({
       nickname={profileData?.nickname}
       introduction={profileData?.introduction}
       profileImageUrl={profileData.profileImageUrl}
-      isMyProfile={getIsMyProfile(memberId)}
+      isMyProfile={getIsMyProfile}
     />
   );
 }