-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] 좌석시야 / 직관등록 구현 #114
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a-fix # Conflicts: # buildSrc/build/kotlin/compileKotlin/cacheable/last-build.bin # buildSrc/build/kotlin/compileKotlin/local-state/build-history.bin # buildSrc/build/libs/buildSrc.jar
… into feat/#108-seat-intuition-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💻주요 작업 내용
🎞리뷰 요청 사항
최종 pr이긴 하지만, 내일 최종 로티 전달 받고 커스텀 갤러리 합친 후 아래 수정 사항 포함해서 최종 확인 후 다시 올릴 것 같습니다 !
@BENDENG1
speechBubble 커스텀뷰 올려주시면 이어서 확인하겠습니다! 그리고 HomeActivity에 작업한 부분이 있어서 나중에 충돌 방지를 위해 확인해주시면 감사하겠습니다.
@Jokwanhee
TODO로 표시해놨는데 (HomeActivity, ViewUploadDialog) 후기 등록 후 시야 후기 상세페이지 게시물로 이동한 후, 방금 작성한 게시물로 포커싱이 되어야 한다고 합니다! 확인해주시면 감사하겠습니다.
추후 야구장이 추가되면 예외 케이스가 이보다 더 늘어날 텐데 어떻게 관리 해야할지 고민이 됩니다아 .. 🥹
혹시 아래 SpotSnackBar의 marginBottom 값이 피그마상 뷰마다 다른 것 같은데, 이에 맞게 수정 중이신 분 계신가요 ??
20240824_194405.mp4