[Feat] Stopwatch 페이지 구현 #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumi-0011
requested review from
woobottle,
wade3420 and
JUNOSHON
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
wade3420
approved these changes
Dec 18, 2023
src/app/stopwatch/page.tsx
Outdated
|
|
||
| const { searchParams } = useSearchParamsTypedValue<ObjectKeys<typeof MISSION_CATEGORIES>>('category'); | ||
| const { step, prevStep, stepLabel, onNextStep } = useTimerStatus(); | ||
| const { seconds, minutes, stepper } = useTimer(step); |
There was a problem hiding this comment.
useStopwatch, useStopwatchStatus 로 네이밍이 변경되면 좋을 것 같아요
| const TEST_MS = 10; | ||
|
|
||
| // 좀 더 의미론적.... useStopwatch | ||
| export default function useStopwatch(status: StepType) { |
There was a problem hiding this comment.
(제안) 나중에 이 hook 을 service파일에 넣어서 테스트를 작성해보는건 어떨까요? status 라는 타입에 따라서 동작하는 것 같아서 서비스로직 같다는 생각이 들었어요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 해결하려는 문제가 무엇인가요?
closed #42 #16
🎉 변경 사항
Dialog컴포넌트가 뜨고,끝내기버튼을 클릭하면/complete페이지로 이동됩니다.🙏 여기는 꼭 봐주세요!