Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Storybook build error fix #64

Merged
merged 2 commits into from
Dec 12, 2023
Merged

[Fix] Storybook build error fix #64

merged 2 commits into from
Dec 12, 2023

Conversation

sumi-0011
Copy link
Member

@sumi-0011 sumi-0011 commented Dec 12, 2023 •
edited
Loading

πŸ€” ν•΄κ²°ν•˜λ €λŠ” λ¬Έμ œκ°€ λ¬΄μ—‡μΈκ°€μš”?

  • ν¬λ‘œλ§ˆν‹± λΉŒλ“œ 이슈 ν•΄κ²°
  • storybook build κ°€ μ•ˆλ¨μ„ 확인
  • storybook Header Component storybook μ‹€ν–‰ 버그 μˆ˜μ •

πŸŽ‰ λ³€κ²½ 사항

import { useRouter } from 'next/navigation'; λ₯Ό μ΄μš©ν•œ μ»΄ν¬λ„ŒνŠΈλ₯Ό μŠ€ν† λ¦¬λΆμ—μ„œ μ‚¬μš©ν•˜λ©΄ λ°œμƒν•˜λŠ” 였λ₯˜μ˜€μŠ΅λ‹ˆλ‹€.
@μ€€ν˜Έ κ°€ λ§ν•œκ²ƒ 처럼 λͺ¨λ“  μŠ€ν† λ¦¬μ— λ„£μœΌλ©΄ λΆˆνŽΈν•˜λ‹ˆ storybook μ„ΈνŒ… 쀑 ν•˜λ‚˜μΈ preview.ts νŒŒμΌμ„ μˆ˜μ •ν•΄μ„œ, λͺ¨λ“  μŠ€ν† λ¦¬μ— κ³΅ν†΅μ μœΌλ‘œ ν¬ν•¨λ˜κ²Œ ν•˜μ˜€μ–΄μš”.

πŸ“š μ°Έκ³ 

@vercel Vercel
Copy link

vercel bot commented Dec 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
10mm-client-web βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Dec 12, 2023 6:51am

@sumi-0011 sumi-0011 self-assigned this Dec 12, 2023
@github-actions GitHub Actions
Copy link
Contributor

πŸš€storybook: https://656f59f07b8e48bf741b98e6-oxqcghzlmv.chromatic.com/

JUNOSHON
JUNOSHON approved these changes Dec 12, 2023
View reviewed changes
.storybook/preview.ts
Comment on lines +13 to +15
nextjs: {
appDirectory: true,
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘πŸ»πŸ‘πŸ‘πŸ»πŸ‘

@sumi-0011 sumi-0011 merged commit 5814228 into develop Dec 12, 2023
3 checks passed
@github-actions GitHub Actions
Copy link
Contributor

πŸš€storybook: https://656f59f07b8e48bf741b98e6-cvbyxudyml.chromatic.com/

@sumi-0011 sumi-0011 deleted the fix/storybook-build branch December 22, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wade3420 wade3420 wade3420 approved these changes

@JUNOSHON JUNOSHON JUNOSHON approved these changes

@woobottle woobottle Awaiting requested review from woobottle woobottle is a code owner

Assignees

@sumi-0011 sumi-0011

Labels
hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sumi-0011 @JUNOSHON @wade3420