Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/monitoring setting #59

Merged
merged 7 commits into from
Dec 12, 2023
Merged

Feat/monitoring setting #59

merged 7 commits into from
Dec 12, 2023

Conversation

JUNOSHON
Copy link
Member

@JUNOSHON JUNOSHON commented Dec 9, 2023

๐Ÿค” ํ•ด๊ฒฐํ•˜๋ ค๋Š” ๋ฌธ์ œ๊ฐ€ ๋ฌด์—‡์ธ๊ฐ€์š”?

  • GA ์„ธํŒ…

๐ŸŽ‰ ๋ณ€๊ฒฝ ์‚ฌํ•ญ

  • ํŒ€ ๊ตฌ๊ธ€ ๊ณ„์ •์œผ๋กœ GA ์„ธํŒ…
  • ์ถ”ํ›„ mixpanel ์„ค์ •์„ ์œ„ํ•ด MonitoringInitializer.tsx ๋กœ ํŽ˜์ด์ง€ ๋กœ๋“œ์‹œ ์„ธํŒ…์ด ์ดˆ๊ธฐํ™”๋˜๋„๋ก ํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ™ ์—ฌ๊ธฐ๋Š” ๊ผญ ๋ด์ฃผ์„ธ์š”!

  • 2d819e8 ์—์„œ ํŠธ๋ž˜ํ‚น ์•„์ด๋””๋ฅผ ๊ณต๊ฐœํ•ด๋ฒ„๋ ธ์Šต๋‹ˆ๋‹ค.. 0fb71e6 ์—์„œ ignore ํ•˜๊ธด ํ–ˆ๋Š”๋ฐ ํ˜น์‹œ ๋ฌธ์ œ ๋ ๊นŒ์š”??

์‚ฌ์šฉ ๋ฐฉ๋ฒ•

๐ŸŒ„ ์Šคํฌ๋ฆฐ์ƒท

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2023-12-09 แ„‹แ…ฉแ„’แ…ฎ 11 25 52

๐Ÿ“š ์ฐธ๊ณ 

Copy link

vercel bot commented Dec 9, 2023

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
10mm-client-web โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Dec 12, 2023 0:29am

Copy link
Contributor

github-actions bot commented Dec 9, 2023


const GA_TRACKING_ID = process.env.NEXT_PUBLIC_GOOGLE_ANALYTICS;

const MonitoringInitializer = () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๊ฑด ์–ด๋””์„œ ํ˜ธ์ถœ๋˜๋Š” ๊ฒƒ์ผ์ง€ ๊ถ๊ธˆํ•ด์š”!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•—.. app ํด๋” ์ƒ์œ„ layout.tsx์—์„œ ํ˜ธ์ถœํ•˜๋ ค๊ณ  ํ–ˆ์Šต๋‹ˆ๋‹ค.
์ˆ˜์ •ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค!!

monitoringInitializer.tsx ์ถ”๊ฐ€
MonitoringInitializer ํ˜ธ์ถœ
Copy link
Collaborator

@wade3420 wade3420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋‚˜์ค‘์— ์ €ํฌ๊ฐ€ ์ปค์Šคํ…€์œผ๋กœ ๋งŒ๋“  ํด๋ฆญ ์ด๋ฒคํŠธ๋ฅผ ๋ฏน์ŠคํŒจ๋„๋กœ ๋ณด๋‚ผ๋•Œ ์–ด๋–ค ์‹์œผ๋กœ ๋ณด๋‚ด์•ผํ•˜๋Š”์ง€ ์˜ˆ์‹œ ํ•œ ์ค„ ์ ์–ด์ฃผ์…”๋„ ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š”~

2d819e8 ์—์„œ ํŠธ๋ž˜ํ‚น ์•„์ด๋””๋ฅผ ๊ณต๊ฐœํ•ด๋ฒ„๋ ธ์Šต๋‹ˆ๋‹ค.. 0fb71e6 ์—์„œ ignore ํ•˜๊ธด ํ–ˆ๋Š”๋ฐ ํ˜น์‹œ ๋ฌธ์ œ ๋ ๊นŒ์š”??

  • ๋ญ... id ์ •๋„๋Š” ๊ดœ์ฐฎ์ง€ ์•Š์„๊นŒ์š”? key ๊ฐ’๋„ ์•„๋‹ˆ๋ผ์„œ...

@@ -15,6 +16,7 @@ export default function RootLayout({ children }: { children: React.ReactNode })
return (
<html lang="en" suppressHydrationWarning className={pretendardFont.variable}>
<body>
<MonitoringInitializer />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOOD

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9d288c3 ์—์„œ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค!! ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค๐Ÿ™Œ๐Ÿป

mixpanel ์ด๋ฒคํŠธ ์ถ”์  ๋ฐฉ๋ฒ• ์ฃผ์„ ์ถ”๊ฐ€
@JUNOSHON JUNOSHON merged commit f24bf5a into develop Dec 12, 2023
3 checks passed
@sumi-0011 sumi-0011 deleted the feat/monitoring-setting branch December 22, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants