[Task] 미션등록페이지 구현 (#31) #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feat/select-page
wade3420
requested review from
woobottle,
JUNOSHON and
sumi-0011
as code owners
sumi-0011
approved these changes
Dec 7, 2023
| @@ -4,7 +4,7 @@ interface ButtonProps extends ButtonHTMLAttributes<HTMLButtonElement> {} | |||
|
|
|||
| const Button: React.FC<ButtonProps> = ({ className, children, ...props }) => { | |||
| return ( | |||
| <button className={`${className}`} {...props} type="button"> | |||
| <button className={`${className}`} type="button" {...props}> | |||
JUNOSHON
approved these changes
Dec 9, 2023
Comment on lines
+22
to
+26
| const logoCss = flex({ | ||
| flexDirection: 'column', | ||
| alignItems: 'center', | ||
| }); | ||
|
|
There was a problem hiding this comment.
이렇게 하면 logoCss가 적용된 태그는 flex-container가 되는건가요??
woobottle
reviewed
Dec 9, 2023
src/app/layout.tsx
Outdated
| @@ -27,4 +27,7 @@ const containerCss = { | |||
| maxWidth: '475px', | |||
| margin: '0 auto', | |||
| minHeight: '100vh', | |||
|
|
|||
| display: 'flex', | |||
There was a problem hiding this comment.
display 속성이 이곳에 있는게 몬가몬가 한것 같아요~
전역에 들어가는 속성이라 적절치 않다고 생각이 들어서요!
There was a problem hiding this comment.
a02c1c8 여기서 수정해 주었습니다
| @@ -4,7 +4,7 @@ interface ButtonProps extends ButtonHTMLAttributes<HTMLButtonElement> {} | |||
|
|
|||
| const Button: React.FC<ButtonProps> = ({ className, children, ...props }) => { | |||
| return ( | |||
| <button className={`${className}`} {...props} type="button"> | |||
| <button className={`${className}`} type="button" {...props}> | |||
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 해결하려는 문제가 무엇인가요?
#31
🎉 변경 사항
🙏 여기는 꼭 봐주세요!
사용 방법
🌄 스크린샷
📚 참고
radio button css
https://www.w3schools.com/howto/howto_css_custom_checkbox.asp
object 관련 type 추론 위한 utils 들은 slash를 참고했습니다. : https://github.com/toss/slash/tree/main/packages/common/utils/src/object
useSearchParams : https://nextjs.org/docs/app/api-reference/functions/use-search-params