[Feat] 현황 full 기능 구현 #530
Merged
[Feat] 현황 full 기능 구현 #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/apis/getQueryKey.ts # src/components/Graph/LastLevelGraph.tsx # src/components/Graph/PastLevelGraph.tsx # src/msw/handlers/index.ts
sumi-0011
requested review from
woobottle,
wade3420 and
JUNOSHON
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
wade3420
reviewed
Feb 11, 2024
| function MissionCalendar({ selectDate, setSelectDate }: Props) { | ||
| const currentData = dayjs(); | ||
|
|
||
| const { date, monthCalendarData, onPrevMonth, onNextMonth, isCurrentMonth } = useCalendar({ |
wade3420
approved these changes
Feb 11, 2024
| }); | ||
|
|
||
| // TODO: 왜 안되지? | ||
| const resultHandlers = [getMissionSummaryList]; |
There was a problem hiding this comment.
handlers/index.ts 에
const handlers = [...missionHandlers, ...recordHandlers, ...memberHandlers, ...followHandlers, ...feedHandlers, ... resultHandlers];
를 추가하셨을까요?
There was a problem hiding this comment.
안되서 충돌해결하다가 충돌나길래 그냥 없앴습니다.
사소해요. 나중에 보시죠
# Conflicts: # src/components/Icon/index.tsx
woobottle
reviewed
Feb 12, 2024
src/apis/result.ts
Outdated
|
|
||
| const RESULT_API = { | ||
| getMissionSummaryList: async (date: string): Promise<MissionSummaryListResponse> => { | ||
| console.log('date: ', date); |
|
|
||
| function MissionList(props: Props) { | ||
| const { data: selectSummaryListData, isLoading } = useGetMissionSummaryList(props.selectDate); | ||
| console.log('selectSummaryListData: ', selectSummaryListData); |
src/app/result/page.tsx
Outdated
| 레벨 안내 | ||
| </Link> | ||
| </section> | ||
| {tabProps.activeTab === 'overall-status' && <OverallStatus />} |
There was a problem hiding this comment.
여기 이 탭값들 이넘으로 관리하고싶은 이슈
| @@ -38,8 +53,7 @@ const outerContainerCss = css({ | |||
| padding: '0px !', // NOTE: padding 0 필수, | |||
| backgroundOrigin: 'border-box', | |||
| backgroundClip: 'content-box, border-box', | |||
| backgroundImage: | |||
| 'linear-gradient(token(colors.bg.surface3), token(colors.bg.surface3)), token(colors.gradients.stroke)', | |||
| backgroundImage: 'linear-gradient(#18181D, #18181D), linear-gradient(0deg, #474A5D00 0%, #474A5D 100%)', | |||
|
|
||
| const MIN_PERCENT = 3; | ||
|
|
||
| export const getPercent = (props: { symbolStack: number; max: number; min: number }): number => { |
src/utils/result.ts
Outdated
| @@ -17,3 +17,12 @@ export const calcProgress = (symbolStack: number) => { | |||
| const currentLevel = getLevel(symbolStack); | |||
| return ((symbolStack - currentLevel.min) / (currentLevel.max - currentLevel.min)) * 100; | |||
| }; | |||
|
|
|||
| const MIN_PERCENT = 3; | |||
There was a problem hiding this comment.
이 친구는 getPercent 함수 안으로 들어가도 될것 같은 이슈인데 의견이 궁금합니도!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 해결하려는 문제가 무엇인가요?
closed #529
🎉 변경 사항
🙏 여기는 꼭 봐주세요!
- 현재는 더미 데이터로 구성되어있습니다.
🌄 스크린샷