타이머 기능 추가 #17
Merged
타이머 기능 추가 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumi-0011
requested review from
woobottle,
wade3420 and
JUNOSHON
as code owners
Closed
wade3420
approved these changes
Dec 2, 2023
| import { css } from '@styled-system/css'; | ||
|
|
||
| export default function TimerPage() { | ||
| const { step, stepLabel, onNextStep } = useTimerStatus(); |
There was a problem hiding this comment.
UI 상태를 step으로 나눈것 배워갑니다! 훅에서 관리하니까 편한것 같아요
| return ( | ||
| <div | ||
| className={css(bgCss, { | ||
| background: step === 'stop' ? '#F2F4F6' : 'linear-gradient(136deg, #FFF1F2 4.76%, #E9EFFF 89.58%)', |
There was a problem hiding this comment.
마이너) background 값들을 각각 상수화 하면 나중에 변경시 편할 것 같은 어떻게 생각하시나요?
There was a problem hiding this comment.
마이너) background 값들을 각각 상수화 하면 나중에 변경시 편할 것 같은 어떻게 생각하시나요?
좋아요! 상수화를 하거나 theme에 추가하면 좋을 것 같습니다!
나중에 디자인 시스템을 전달받으면서 같이 변경하면 좋을 것 같아요 :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 해결하려는 문제가 무엇인가요?
🎉 변경 사항
🙏 여기는 꼭 봐주세요!
layout.tsx부분을 수정했는데, 맘에 들지 않아요.. 근데 와프 후 디자인이 변경되면 수정되어야 하는 부분이라 해당 이슈는 패쓰 부탁드립니다.🌄 스크린샷