✨ 미션 선택 Bottom Sheet 연결 #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/app/select/MissionRegistration.tsx
sumi-0011
requested review from
woobottle,
wade3420 and
JUNOSHON
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
woobottle
reviewed
Dec 22, 2023
| const useToggle = (initialValue?: boolean): Return => { | ||
| const [value, setValue] = useState(initialValue ?? false); | ||
|
|
||
| const setTrue = useCallback(() => { |
There was a problem hiding this comment.
혹시 useCallback으로 하지 않아도 될것 같은데
설정해주신 이유가 궁금해요!
JUNOSHON
reviewed
Dec 22, 2023
| {required && <span className={asterisk}>*</span>} | ||
| {required && <span className={asterisk}> *</span>} |
There was a problem hiding this comment.
이 부분은 오타인거겠죠?? 제가 뷰 구현하다 실수한 부분같아요 죄송합니다ㅠ_ㅠ
woobottle
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 변경 사항
🙏 여기는 꼭 봐주세요!
🌄 스크린샷
📚 참고