Renames additional forms chapter for 21-526 #34376
Draft
+15
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
master/vabc/jr/rename-additional-forms-100725/main
freeheeling
reviewed
Jan 30, 2025
| additionalFormsChapterWrapper: { | ||
| title: 'Additional forms to support your claim', | ||
| path: 'additional-forms', | ||
| depends: formData => showAdditionalFormsChapter(formData), |
There was a problem hiding this comment.
I believe the utility showAdditionalFormsChapter can be removed as it is only being called here.
freeheeling
reviewed
Jan 30, 2025
| depends: formData => showForm0781Pages(formData), | ||
| uiSchema: workflowChoicePage.uiSchema, | ||
| schema: workflowChoicePage.schema, | ||
| }, | ||
| manualUploadPage: { | ||
| path: | ||
| 'disability/file-disability-claim-form-21-526ez/additional-forms/mental-health-statement/upload', | ||
| 'disability/file-disability-claim-form-21-526ez/mental-health-form-0781/upload', |
There was a problem hiding this comment.
Nathan may address this in a future PR, but this path can be shortened to 'mental-health-form-0781/upload'.
freeheeling
reviewed
Jan 30, 2025
| @@ -1,7 +1,7 @@ | |||
| import React from 'react'; | |||
|
|
|||
| export const form0781HeadingTag = 'VA FORM 21-0781'; | |||
| export const additionalFormsTitle = 'Additional Forms'; | |||
| // export const additionalFormsTitle = 'Additional Forms'; | |||
There was a problem hiding this comment.
This could probably be removed as it's not being utilized anywhere else.
freeheeling
requested changes
Jan 30, 2025
There was a problem hiding this comment.
Associated files that can be deleted include:
- src/applications/disability-benefits/all-claims/tests/pages/additionalFormsChapterWrapper.unit.spec.js
- src/applications/disability-benefits/all-claims/pages/additionalFormsChapterWrapper.js
Paths in src/applications/disability-benefits/all-claims/pages/form0781/traumaticEventsPages.js will also need to be revised.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #100725 by removing the additional forms section from VA 21-526EZ.
Are you removing, renaming or moving a folder in this PR?
Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the
#sitewide-public-websitesSlack channel for questions.Did you change site-wide styles, platform utilities or other infrastructure?
Summary
Related issue(s)
Testing done
Screenshots
Before
After
Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).
What areas of the site does it impact?
Just the 21-526 form
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?